chore: Accumulated small changes #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2293 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 450 450
Lines 25408 25408
Branches 11727 11727
=======================================
Hits 12521 12521
Misses 4549 4549
Partials 8338 8338
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 3b1bb13Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
AJPfleger
reviewed
Jul 11, 2023
AJPfleger
approved these changes
Jul 11, 2023
acts-project-service
added
the
Fails Athena tests
CarloVarni
removed
the
Fails Athena tests
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
I pulled this out of acts-project#2086 since it is not relevant there but I would still like to merge them. These changes are random improvements across the code base which should not have any effects on CPU or physics performance.
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
…roject#2086) Our full chain pulls are in a bad state. Looks like the reconstruction and simulation energy loss did not match up. This PR switches the Fatras interactions on which should bring our pulls back to standard normal distribution. Fixes - acts-project#1643 Blocked by - acts-project#2157 - acts-project#2239 - acts-project#2295 - acts-project#2293 - acts-project#2294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled this out of #2086 since it is not relevant there but I would still like to merge them. These changes are random improvements across the code base which should not have any effects on CPU or physics performance.