Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter for particles which originate from the beam pipe #2300

Merged

Conversation

andiwand
Copy link
Contributor

Pythia will create a bunch of particles outside of the beampip. We expect the event simulation to handle decays inside the detector. In this PR I add filters to the ODD and ITk full chain.

@andiwand andiwand added the 🚧 WIP Work-in-progress label Jul 12, 2023
@andiwand andiwand added this to the next milestone Jul 12, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2300 (33c18a7) into main (cb16df8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2300   +/-   ##
=======================================
  Coverage   49.27%   49.27%           
=======================================
  Files         450      450           
  Lines       25407    25407           
  Branches    11728    11728           
=======================================
  Hits        12520    12520           
  Misses       4549     4549           
  Partials     8338     8338           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

📊 Physics performance monitoring for 33c18a7

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand removed the 🚧 WIP Work-in-progress label Jul 13, 2023
@andiwand andiwand marked this pull request as ready for review July 13, 2023 07:40
@kodiakhq kodiakhq bot merged commit 9dff59f into acts-project:main Jul 13, 2023
56 of 57 checks passed
@andiwand andiwand deleted the feat-fullchain-filter-beampip-particles branch July 13, 2023 14:46
@paulgessinger paulgessinger modified the milestones: next, v27.2.0 Jul 24, 2023
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Jul 24, 2023
…roject#2300)

Pythia will create a bunch of particles outside of the beampip. We expect the event simulation to handle decays inside the detector. In this PR I add filters to the ODD and ITk full chain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants