-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GX2F (experimental) + unit test #2305
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2305 +/- ##
==========================================
- Coverage 49.70% 49.54% -0.16%
==========================================
Files 452 453 +1
Lines 25468 25679 +211
Branches 11651 11811 +160
==========================================
+ Hits 12658 12722 +64
- Misses 4578 4583 +5
- Partials 8232 8374 +142
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'll draft this while it's still being worked on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! :)
Some remarks about dead code etc.
You could make the std::cout
s to logging statements (I left a bunch of comments)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side
Just updated the title so it doesn't get confused with the examples framework |
Invalidated by push of 0ec11a6
Unrelated failure. |
A first implementation of the new Global Chi Square Fitter (GX2F). It is probably not performant and lacks many features but it is stable and testable. That's why it should live in the namespace
Experimental
.