Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GX2F (experimental) + unit test #2305

Merged
merged 22 commits into from
Aug 24, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Jul 14, 2023

A first implementation of the new Global Chi Square Fitter (GX2F). It is probably not performant and lacks many features but it is stable and testable. That's why it should live in the namespace Experimental.

@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #2305 (fb5575a) into main (d8b6d67) will decrease coverage by 0.16%.
Report is 1 commits behind head on main.
The diff coverage is 33.60%.

@@            Coverage Diff             @@
##             main    #2305      +/-   ##
==========================================
- Coverage   49.70%   49.54%   -0.16%     
==========================================
  Files         452      453       +1     
  Lines       25468    25679     +211     
  Branches    11651    11811     +160     
==========================================
+ Hits        12658    12722      +64     
- Misses       4578     4583       +5     
- Partials     8232     8374     +142     
Files Changed Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.hpp 89.47% <ø> (ø)
...include/Acts/Vertexing/FullBilloirVertexFitter.ipp 27.97% <3.57%> (-5.64%) ⬇️
...nclude/Acts/Vertexing/KalmanVertexTrackUpdater.ipp 14.92% <13.88%> (-0.87%) ⬇️
...e/include/Acts/Vertexing/IterativeVertexFinder.ipp 27.20% <33.33%> (ø)
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 39.26% <39.26%> (ø)
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 40.81% <50.00%> (+0.06%) ⬆️
...ore/include/Acts/Vertexing/KalmanVertexUpdater.ipp 28.57% <66.66%> (ø)
Core/include/Acts/Vertexing/TrackAtVertex.hpp 66.66% <66.66%> (-33.34%) ⬇️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 44.73% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AJPfleger AJPfleger marked this pull request as ready for review July 26, 2023 12:27
@paulgessinger
Copy link
Member

I'll draft this while it's still being worked on.

@paulgessinger paulgessinger marked this pull request as draft August 4, 2023 12:59
@AJPfleger AJPfleger marked this pull request as ready for review August 22, 2023 10:45
@benjaminhuth benjaminhuth added this to the next milestone Aug 22, 2023
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)
Some remarks about dead code etc.
You could make the std::couts to logging statements (I left a bunch of comments)...

Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
benjaminhuth
benjaminhuth previously approved these changes Aug 23, 2023
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side

@benjaminhuth benjaminhuth changed the title feat: GX2F - Experimental frame work, simple fit feat: GX2F (experimental) + unit test Aug 23, 2023
@benjaminhuth
Copy link
Member

Just updated the title so it doesn't get confused with the examples framework

@paulgessinger paulgessinger merged commit f90906c into acts-project:main Aug 24, 2023
53 of 56 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 24, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.0.0 Aug 25, 2023
@paulgessinger
Copy link
Member

Unrelated failure.

@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants