-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve documentation on surface classes #2323
docs: Improve documentation on surface classes #2323
Conversation
In particular `LineSurface` after acts-project#2287
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2323 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 453 453
Lines 25511 25511
Branches 11706 11706
=======================================
Hits 12648 12648
Misses 4579 4579
Partials 8284 8284
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊: Physics performance monitoring for 36ef813physmon summary
|
Co-authored-by: felix-russo <72298366+felix-russo@users.noreply.github.com>
Co-authored-by: felix-russo <72298366+felix-russo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise good to go
This reverts commit 87b816a.
@paulgessinger if you like we can merge this already and fix the images afterwards since it seems to be an unrelated problem |
I'm just doing some more CI debugging |
Ok, dead end for right now. Let's merge. |
Failure with a missing symbol. This seems weird, I'm investigating. |
Confirmed technical error. |
In particular
LineSurface
after #2287.