Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve documentation on surface classes #2323

Merged
merged 14 commits into from
Aug 15, 2023

Conversation

paulgessinger
Copy link
Member

In particular LineSurface after #2287.

@paulgessinger paulgessinger added this to the next milestone Jul 27, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Documentation Affects the documentation labels Jul 27, 2023
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2323 (36ef813) into main (f96b048) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2323   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25511    25511           
  Branches    11706    11706           
=======================================
  Hits        12648    12648           
  Misses       4579     4579           
  Partials     8284     8284           
Files Changed Coverage Δ
Core/include/Acts/Definitions/Direction.hpp 90.24% <ø> (ø)
Core/include/Acts/Geometry/GeometryIdentifier.hpp 94.59% <ø> (ø)
Core/include/Acts/Surfaces/DiscSurface.hpp 100.00% <ø> (ø)
Core/include/Acts/Surfaces/LineSurface.hpp 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Core/include/Acts/Surfaces/DiscSurface.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Surfaces/DiscSurface.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Surfaces/DiscSurface.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Surfaces/DiscSurface.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Surfaces/DiscSurface.hpp Outdated Show resolved Hide resolved
docs/core/geometry.md Outdated Show resolved Hide resolved
docs/core/geometry.md Outdated Show resolved Hide resolved
docs/core/geometry.md Outdated Show resolved Hide resolved
docs/core/geometry.md Outdated Show resolved Hide resolved
docs/core/geometry.md Outdated Show resolved Hide resolved
paulgessinger and others added 5 commits August 9, 2023 14:35
Co-authored-by: felix-russo <72298366+felix-russo@users.noreply.github.com>
Co-authored-by: felix-russo <72298366+felix-russo@users.noreply.github.com>
Copy link
Contributor

@felix-russo felix-russo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good to go

Core/include/Acts/Surfaces/CylinderSurface.hpp Outdated Show resolved Hide resolved
andiwand
andiwand previously approved these changes Aug 14, 2023
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Aug 14, 2023
@andiwand
Copy link
Contributor

@paulgessinger if you like we can merge this already and fix the images afterwards since it seems to be an unrelated problem

@paulgessinger
Copy link
Member Author

I'm just doing some more CI debugging

@paulgessinger
Copy link
Member Author

Ok, dead end for right now. Let's merge.

@github-actions github-actions bot removed the Infrastructure Changes to build tools, continous integration, ... label Aug 14, 2023
@kodiakhq kodiakhq bot merged commit 430eb1e into acts-project:main Aug 15, 2023
54 of 55 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 15, 2023
@paulgessinger
Copy link
Member Author

Failure with a missing symbol. This seems weird, I'm investigating.

@paulgessinger paulgessinger deleted the geometry-docs-update branch August 15, 2023 15:14
@paulgessinger
Copy link
Member Author

paulgessinger commented Aug 15, 2023

Confirmed technical error.

@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 15, 2023
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants