Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Create job summaries in python #2339

Merged
merged 14 commits into from
Aug 3, 2023
Merged

ci: Create job summaries in python #2339

merged 14 commits into from
Aug 3, 2023

Conversation

paulgessinger
Copy link
Member

No description provided.

@paulgessinger paulgessinger added this to the next milestone Aug 2, 2023
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited

Codecov Report

Merging #2339 (4f1e3b2) into main (271cbf8) will not change coverage.
The diff coverage is n/a.

❗ Current head 4f1e3b2 differs from pull request most recent head 40b6fd5. Consider uploading reports for the commit 40b6fd5 to get more accurate results

@@           Coverage Diff           @@
##             main    #2339   +/-   ##
=======================================
  Coverage   49.66%   49.66%           
=======================================
  Files         453      453           
  Lines       25533    25533           
  Branches    11706    11706           
=======================================
  Hits        12680    12680           
  Misses       4574     4574           
  Partials     8279     8279

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited

📊 Physics performance monitoring for 40b6fd5

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger paulgessinger marked this pull request as ready for review August 3, 2023 07:50
@paulgessinger paulgessinger marked this pull request as draft August 3, 2023 07:50
@paulgessinger
Copy link
Member Author

The texme header doesn't work as well as I thought it would, and also the links don't currently work in the job summary (I have an idea how to fix that) so I'll switch to just using multiple separate outputs from python

andiwand
andiwand previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@paulgessinger paulgessinger marked this pull request as ready for review August 3, 2023 10:02
@paulgessinger
Copy link
Member Author

Ok, I added some functionality to herald to redirect to an artifact from a run id while maintaining paths. Now the physmon summary markdown should contain working links.

andiwand
andiwand previously approved these changes Aug 3, 2023
View reviewed changes
andiwand
andiwand previously approved these changes Aug 3, 2023
View reviewed changes
CI/physmon/summary.py Outdated Show resolved Hide resolved
CI/physmon/summary.py Outdated Show resolved Hide resolved
CI/physmon/summary.py Show resolved Hide resolved
CI/physmon/summary.py Outdated Show resolved Hide resolved
@paulgessinger paulgessinger mentioned this pull request Aug 3, 2023
Merged
@kodiakhq kodiakhq bot merged commit b5babcb into acts-project:main Aug 3, 2023
53 of 54 checks passed
@paulgessinger paulgessinger deleted the job-summary branch August 3, 2023 14:32
@github-actions github-actions bot removed the automerge label Aug 3, 2023
@acts-project-service
Copy link
Collaborator

acts-project-service commented Aug 3, 2023 •
edited

✅ Athena integration test results

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

kodiakhq bot pushed a commit that referenced this pull request Aug 4, 2023
@paulgessinger
ci: Physmon comment report pipes through summary (#2342)
3f4cbab 
This PR changes the physmon report CI job to basically pipe through the `summary.md` that we create inside the physmon job to the comment. This should be more robust than what we had before.

Blocked by
- #2339
@paulgessinger paulgessinger modified the milestones: next, v28.1.0 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Milestone
v28.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulgessinger @acts-project-service @andiwand