refactor!: Remove explicit geometry ID from source link #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the memory footprint. The access to the surface is now done using a delegate (which I typedef right next to Source Link itself). Components need to handle this individually.
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2356 +/- ##
==========================================
- Coverage 49.54% 49.52% -0.02%
==========================================
Files 453 453
Lines 25679 25677 -2
Branches 11811 11815 +4
==========================================
- Hits 12722 12716 -6
Misses 4583 4583
- Partials 8374 8378 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This allows python/pytest to catch them and report as failures, instead of tearing down the whole process. I don't think we care about the runtime implications of throwing exceptions here.
github-actions
bot
added
the
Infrastructure
This reverts commit 8c742a0.
github-actions
bot
removed
the
Infrastructure
|
Still some tests seem to rely on the old interface @paulgessinger |
|
This should hopefully finally be good. |
|
RTD is stuck, I'm merging manually. |
acts-project-service
added
the
Breaks Athena build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the memory footprint. The access to the surface is now done using a delegate (which I typedef right next to Source Link itself). Components need to handle this individually.