Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fittedParams -> fittedMomentum in TrackAtVertex struct (#2359)" #2391

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

felix-russo
Copy link
Contributor

Let's wait for v30 with this!

@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Vertexing Changes Performance labels Aug 23, 2023
@paulgessinger paulgessinger added this to the v29.0.0 milestone Aug 23, 2023
@paulgessinger paulgessinger marked this pull request as ready for review August 23, 2023 09:15
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2391 (2a7bc6e) into main (d8b6d67) will decrease coverage by 0.11%.
The diff coverage is 22.98%.

@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
- Coverage   49.70%   49.60%   -0.11%     
==========================================
  Files         452      452              
  Lines       25468    25516      +48     
  Branches    11651    11702      +51     
==========================================
- Hits        12658    12656       -2     
- Misses       4578     4579       +1     
- Partials     8232     8281      +49     
Files Changed Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.hpp 89.47% <ø> (ø)
...include/Acts/Vertexing/FullBilloirVertexFitter.ipp 27.97% <3.57%> (-5.64%) ⬇️
...nclude/Acts/Vertexing/KalmanVertexTrackUpdater.ipp 14.92% <13.88%> (-0.87%) ⬇️
...e/include/Acts/Vertexing/IterativeVertexFinder.ipp 27.20% <33.33%> (ø)
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 40.81% <50.00%> (+0.06%) ⬆️
...ore/include/Acts/Vertexing/KalmanVertexUpdater.ipp 28.57% <66.66%> (ø)
Core/include/Acts/Vertexing/TrackAtVertex.hpp 66.66% <66.66%> (-33.34%) ⬇️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 44.73% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger merged commit 557c0f3 into acts-project:main Aug 23, 2023
53 of 55 checks passed
@acts-project-service acts-project-service added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Aug 23, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 29, 2023
@felix-russo felix-russo deleted the revert-fitted-momentum branch August 30, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ... Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants