-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: "fittedParams -> fittedMomentum in TrackAtVertex struct (#2359)" #2391
Merged
paulgessinger
merged 3 commits into
acts-project:main
from
felix-russo:revert-fitted-momentum
Aug 23, 2023
Merged
revert: "fittedParams -> fittedMomentum in TrackAtVertex struct (#2359)" #2391
paulgessinger
merged 3 commits into
acts-project:main
from
felix-russo:revert-fitted-momentum
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Infrastructure
Changes to build tools, continous integration, ...
Component - Examples
Affects the Examples module
Vertexing
Changes Performance
labels
Aug 23, 2023
paulgessinger
approved these changes
Aug 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #2391 +/- ##
==========================================
- Coverage 49.70% 49.60% -0.11%
==========================================
Files 452 452
Lines 25468 25516 +48
Branches 11651 11702 +51
==========================================
- Hits 12658 12656 -2
- Misses 4578 4579 +1
- Partials 8232 8281 +49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
approved these changes
Aug 23, 2023
acts-project-service
added
Breaks Athena build
This PR breaks the Athena build
Fails Athena tests
This PR causes a failure in the Athena tests
labels
Aug 23, 2023
paulgessinger
removed
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Changes Performance
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Infrastructure
Changes to build tools, continous integration, ...
Vertexing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's wait for v30 with this!