Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add obj drawing possibility as python function #2400

Merged
merged 9 commits into from
Aug 28, 2023

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Aug 25, 2023

Title says it all, since Obj is a natural visualisation of the Core library that doesn't need any extension, it's also handy from the python side.

This practically allows you to do

acts.drawSurfacesObj(surfaces, context, colouring, filename)

@asalzburger asalzburger added this to the next milestone Aug 25, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c1e0cb5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2400   +/-   ##
=======================================
  Coverage        ?   49.53%           
=======================================
  Files           ?      453           
  Lines           ?    25692           
  Branches        ?    11819           
=======================================
  Hits            ?    12726           
  Misses          ?     4583           
  Partials        ?     8383           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@asalzburger asalzburger requested review from felix-russo and removed request for AJPfleger August 28, 2023 11:09
@asalzburger
Copy link
Contributor Author

Hi @felix-russo - this is a super small PR, which I would need at some other (Geant4/DD4hep) related PRs, would you mind reviewing it?

Copy link
Contributor

@felix-russo felix-russo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I still made a few very small comments, which might all be redundant

Examples/Python/src/Obj.cpp Show resolved Hide resolved
Examples/Python/src/Obj.cpp Outdated Show resolved Hide resolved
Examples/Python/src/Obj.cpp Show resolved Hide resolved
Co-authored-by: felix-russo <72298366+felix-russo@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 22bdf2a into acts-project:main Aug 28, 2023
56 checks passed
@paulgessinger paulgessinger modified the milestones: next, v29.0.0 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants