-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add obj drawing possibility as python function #2400
feat: add obj drawing possibility as python function #2400
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2400 +/- ##
=======================================
Coverage ? 49.53%
=======================================
Files ? 453
Lines ? 25692
Branches ? 11819
=======================================
Hits ? 12726
Misses ? 4583
Partials ? 8383 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @felix-russo - this is a super small PR, which I would need at some other (Geant4/DD4hep) related PRs, would you mind reviewing it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I still made a few very small comments, which might all be redundant
Co-authored-by: felix-russo <72298366+felix-russo@users.noreply.github.com>
Title says it all, since Obj is a natural visualisation of the Core library that doesn't need any extension, it's also handy from the python side.
This practically allows you to do