Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more unit tests and python for Geant4 conversion + documentation #2401

Conversation

asalzburger
Copy link
Contributor

First step to improve the Geant4 conversion example:

  • new, extended unit tests
  • new convenience function from python to test conversion
  • first documentation slides

@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation labels Aug 25, 2023
@asalzburger asalzburger added this to the next milestone Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2401 (c6bdfa1) into main (c535c5d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2401   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         453      453           
  Lines       25692    25692           
  Branches    11819    11819           
=======================================
  Hits        12726    12726           
  Misses       4583     4583           
  Partials     8383     8383           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@asalzburger asalzburger force-pushed the feat-add-geant4-conversion-documentation branch from 042aeec to 70853e4 Compare August 28, 2023 08:18
@asalzburger asalzburger force-pushed the feat-add-geant4-conversion-documentation branch from 78b8dba to fd225fc Compare August 28, 2023 09:00
@asalzburger asalzburger requested review from dimitra97 and removed request for andiwand August 28, 2023 11:04
@asalzburger
Copy link
Contributor Author

Hi @dimitra97 - since you have some Geant4 experience, would you mind reviewing this one?

@asalzburger asalzburger merged commit c1e0cb5 into acts-project:main Aug 28, 2023
56 checks passed
@asalzburger asalzburger deleted the feat-add-geant4-conversion-documentation branch August 28, 2023 13:26
@asalzburger asalzburger restored the feat-add-geant4-conversion-documentation branch August 28, 2023 13:31
@asalzburger asalzburger deleted the feat-add-geant4-conversion-documentation branch August 28, 2023 14:28
@paulgessinger paulgessinger modified the milestones: next, v29.0.0 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants