-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more unit tests and python for Geant4 conversion + documentation #2401
Merged
asalzburger
merged 7 commits into
acts-project:main
from
asalzburger:feat-add-geant4-conversion-documentation
Aug 28, 2023
Merged
feat: add more unit tests and python for Geant4 conversion + documentation #2401
asalzburger
merged 7 commits into
acts-project:main
from
asalzburger:feat-add-geant4-conversion-documentation
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Component - Documentation
Affects the documentation
labels
Aug 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #2401 +/- ##
=======================================
Coverage 49.53% 49.53%
=======================================
Files 453 453
Lines 25692 25692
Branches 11819 11819
=======================================
Hits 12726 12726
Misses 4583 4583
Partials 8383 8383 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
asalzburger
force-pushed
the
feat-add-geant4-conversion-documentation
branch
from
August 28, 2023 08:18
042aeec
to
70853e4
Compare
asalzburger
force-pushed
the
feat-add-geant4-conversion-documentation
branch
from
August 28, 2023 09:00
78b8dba
to
fd225fc
Compare
Hi @dimitra97 - since you have some Geant4 experience, would you mind reviewing this one? |
dimitra97
reviewed
Aug 28, 2023
dimitra97
approved these changes
Aug 28, 2023
dimitra97
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Documentation
Affects the documentation
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to improve the Geant4 conversion example: