Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TrackSelector supports eta-dependent cuts #2405

Merged
merged 10 commits into from
Aug 30, 2023

Conversation

paulgessinger
Copy link
Member

This changes TrackSelector so that eta dependent cuts can be supplied. To this end, a new nested struct CutConfig is introduced. The existing Config struct is auto-convertible from that struct, and will produce a single cut set for all eta.

You can also supply Config with a vector of absolute eta bin edges and correspondingly sized (N-1) vector of CutConfig structs. The selector will then look up the associated cut value.

Note: the CutConfig properties etaMin, etaMax, absEtaMin and absEtaMax are only supported if there is a single cut configuration with an abs eta bin from 0.0 to +infinity.

The TrackSelector constructor checks consistency of the configuration.

@paulgessinger paulgessinger added this to the next milestone Aug 28, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Track Finding labels Aug 28, 2023
@paulgessinger paulgessinger marked this pull request as draft August 28, 2023 15:49
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2405 (20ba180) into main (2beed70) will increase coverage by 0.09%.
The diff coverage is 72.34%.

@@            Coverage Diff             @@
##             main    #2405      +/-   ##
==========================================
+ Coverage   49.59%   49.69%   +0.09%     
==========================================
  Files         453      454       +1     
  Lines       25694    25796     +102     
  Branches    11808    11850      +42     
==========================================
+ Hits        12744    12820      +76     
- Misses       4572     4575       +3     
- Partials     8378     8401      +23     
Files Changed Coverage Δ
Core/include/Acts/TrackFinding/TrackSelector.hpp 74.50% <72.34%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger marked this pull request as ready for review August 29, 2023 11:05
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We initially discussed using the Range1D class, but this is not necessary here it seems.

@kodiakhq kodiakhq bot merged commit ed0bb27 into acts-project:main Aug 30, 2023
56 checks passed
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Sep 6, 2023
I noticed that the eta-dependent cuts introduced in acts-project#2405 are a not
actually backwards compatible. This should hoopefully fix that.
paulgessinger added a commit that referenced this pull request Sep 7, 2023
I noticed that the eta-dependent cuts introduced in #2405 are a not
actually backwards compatible. This should hoopefully fix that.
@paulgessinger paulgessinger modified the milestones: next, v29.1.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants