-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TrackSelector supports eta-dependent cuts #2405
feat: TrackSelector supports eta-dependent cuts #2405
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2405 +/- ##
==========================================
+ Coverage 49.59% 49.69% +0.09%
==========================================
Files 453 454 +1
Lines 25694 25796 +102
Branches 11808 11850 +42
==========================================
+ Hits 12744 12820 +76
- Misses 4572 4575 +3
- Partials 8378 8401 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We initially discussed using the Range1D class, but this is not necessary here it seems.
I noticed that the eta-dependent cuts introduced in acts-project#2405 are a not actually backwards compatible. This should hoopefully fix that.
I noticed that the eta-dependent cuts introduced in #2405 are a not actually backwards compatible. This should hoopefully fix that.
This changes
TrackSelector
so that eta dependent cuts can be supplied. To this end, a new nested structCutConfig
is introduced. The existingConfig
struct is auto-convertible from that struct, and will produce a single cut set for all eta.You can also supply
Config
with a vector of absolute eta bin edges and correspondingly sized (N-1
) vector ofCutConfig
structs. The selector will then look up the associated cut value.Note: the
CutConfig
propertiesetaMin
,etaMax
,absEtaMin
andabsEtaMax
are only supported if there is a single cut configuration with an abs eta bin from0.0
to+infinity
.The
TrackSelector
constructor checks consistency of the configuration.