Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add single lookup multi surfaces #2412

Merged

Conversation

asalzburger
Copy link
Contributor

Adding the possibility to build a SurfaceArray with multiple entries, but still using the SurfaceArray::SingleLookup directive.

@asalzburger asalzburger added this to the next milestone Aug 30, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2412 (8fc2bce) into main (f972f33) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
- Coverage   49.68%   49.68%   -0.01%     
==========================================
  Files         454      454              
  Lines       25799    25800       +1     
  Branches    11849    11850       +1     
==========================================
  Hits        12818    12818              
  Misses       4580     4580              
- Partials     8401     8402       +1     
Files Changed Coverage Δ
Core/include/Acts/Surfaces/SurfaceArray.hpp 52.54% <0.00%> (-0.45%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 96b2e07 into acts-project:main Aug 31, 2023
59 checks passed
@asalzburger asalzburger deleted the feat-add-single-lookup-multi-surfaces branch August 31, 2023 07:31
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 31, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.1.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants