feat: geant4 gdml detector - ODD light part 1 #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2424 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 458 458
Lines 25946 25949 +3
Branches 11918 11919 +1
=======================================
+ Hits 12896 12899 +3
- Misses 4595 4596 +1
+ Partials 8455 8454 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hey @niermann999 - this is the first step to build ODD light. |
asalzburger
changed the title
asalzburger
changed the title
niermann999
reviewed
Sep 11, 2023
|
All comments addressed. |
niermann999
approved these changes
Sep 12, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
This PR adds the possibility to create a grid based start volume lookup for navigation. It reduces the time for 1000 lookups in the ODD light example from `20 ms` to `1.5 ms` and hence `1.5 µs` per lookup. This sits on top of #2424 and will wait until this one is merged.
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
This PR introduces: - an interface of a `Acts::Experimental::IGeometryIdGenerator` tool - a standard `Acts::Experimental::GeometryIdGenerator` implementation - slots in the detector building to attach those generators - a check in the `Acts::Detector` class that surfaces have unique geometry ids - a `Acts::GeometryHierarchyMap<Surface>` for the detector - unit tests for all of those - finally the ODD light with geometry id settings as the ODD standard This is a squashed version of #2439 - It sits on top of #2424 and #2436 and will wait until those are merged.
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
This PR introduces: - an interface of a `Acts::Experimental::IGeometryIdGenerator` tool - a standard `Acts::Experimental::GeometryIdGenerator` implementation - slots in the detector building to attach those generators - a check in the `Acts::Detector` class that surfaces have unique geometry ids - a `Acts::GeometryHierarchyMap<Surface>` for the detector - unit tests for all of those - finally the ODD light with geometry id settings as the ODD standard This is a squashed version of acts-project#2439 - It sits on top of acts-project#2424 and acts-project#2436 and will wait until those are merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build ODD light detector in new Detector frame.
By doing so, two things had to be corrected:
PolyhedronReferenceGeneratoris now templated on the number of segments and whether the center of gravity is addedKdtSurfacesProvidernow calculated the center of gravity of the reference points, BUT already in the casted frame, this avoid e.g. a cylinder to be assigned to (x,y) = (0,0) if not needed thereIt also removed the
odd_from_json.pyto be replaced by theodd_light.py, which can be fed in from json, Geant4, DD4hep, TGeo, ...