feat: Perform the Greedy Solver after the ML Solver #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2434 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 455 455
Lines 25840 25840
Branches 11861 11861
=======================================
Hits 12843 12843
Misses 4592 4592
Partials 8405 8405 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
|
this requires some reference file changes |
Ah yes, I forgot about that. I am on it |
github-actions
bot
added
Infrastructure
andiwand
approved these changes
Sep 8, 2023
acts-project-service
added
the
Breaks Athena build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modify the odd full chain to call the Greedy solver on the output of the MLSolver. This has been tested on ttbar mu=200 PU and removes almost all the remaining duplicates at almost no cost in term of efficiency and speed.
This PR also change the full chain default back to mu=200 and the seeding range to match the ODD eta range.