Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: volume agnostic material interaction #2465

Conversation

asalzburger
Copy link
Contributor

This PR introduces an InteractionVolum helper class that allows to switch between TrackingVolume and DetectorVolume and through that makes the material interaction recording struct quasi volume agnostic.

@asalzburger asalzburger added this to the next milestone Sep 19, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2465 (b558e28) into main (af4fb26) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##             main    #2465   +/-   ##
=======================================
  Coverage   49.81%   49.82%           
=======================================
  Files         465      466    +1     
  Lines       26135    26139    +4     
  Branches    11982    11983    +1     
=======================================
+ Hits        13020    13023    +3     
  Misses       4615     4615           
- Partials     8500     8501    +1     
Files Changed Coverage Δ
...ts/Propagator/detail/VolumeMaterialInteraction.hpp 90.47% <ø> (ø)
...ore/include/Acts/Propagator/MaterialInteractor.hpp 39.72% <66.66%> (ø)
Core/include/Acts/Material/MaterialInteraction.hpp 75.00% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! I just have one question and after I can approve.

@kodiakhq kodiakhq bot merged commit dc13bc0 into acts-project:main Sep 20, 2023
60 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Sep 20, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.0.0 Sep 21, 2023
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
This PR introduces an `InteractionVolum` helper class that allows to switch between `TrackingVolume` and `DetectorVolume` and through that makes the material interaction recording struct quasi volume agnostic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants