fix: (Layer-based) Geometry construction handles layerless volumes #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2514 +/- ##
==========================================
- Coverage 49.79% 49.78% -0.01%
==========================================
Files 466 466
Lines 26262 26272 +10
Branches 12063 12069 +6
==========================================
+ Hits 13076 13079 +3
- Misses 4613 4617 +4
- Partials 8573 8576 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In calorimeter developments with ODD we noticed that if DD4hep produces a volume without layers, which currently is the case with the calorimeter implementation that we have there, the geometry construction will fail to produce a geometry. This changes the layer-based geometry construction to ignore volumes without layers for now.