fix: MaterialComposition analysis #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a fixed histogram bin range, and was default-constructing invalid elements that would then lead to a SEGFAULT when an element outside of the histogram range was to be filled. This PR extends the histogram, and also adds a specific check and exception for the error case.
andiwand
previously approved these changes
Oct 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #2526 +/- ##
=======================================
Coverage 49.77% 49.77%
=======================================
Files 466 466
Lines 26310 26310
Branches 12093 12093
=======================================
Hits 13095 13095
Misses 4616 4616
Partials 8599 8599 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
asalzburger
previously approved these changes
Oct 10, 2023
paulgessinger
dismissed stale reviews from asalzburger and andiwand
via
b99ac0a
|
@asalzburger can you click approve one more time? |
andiwand
approved these changes
Oct 11, 2023
paulgessinger
added a commit
that referenced
this pull request
Oct 11, 2023
This has a fixed histogram bin range, and was default-constructing invalid elements that would then lead to a SEGFAULT when an element outside of the histogram range was to be filled. This PR extends the histogram, and also adds a specific check and exception for the error case. These do not have to be set manually.
acts-project-service
added
the
Fails Athena tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a fixed histogram bin range, and was default-constructing invalid elements that would then lead to a SEGFAULT when an element outside of the histogram range was to be filled.
This PR extends the histogram, and also adds a specific check and exception for the error case.
These do not have to be set manually.