refactor: Refactor and fix accuracy property in ConstrainedStep
#2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2532 +/- ##
==========================================
+ Coverage 49.76% 49.77% +0.01%
==========================================
Files 466 466
Lines 26353 26354 +1
Branches 12100 12098 -2
==========================================
+ Hits 13114 13119 +5
Misses 4632 4632
+ Partials 8607 8603 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
since seeding performance changed I think that the fatras ttbar simulation changed a bit. but in general physmon looks okay to me |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
I noticed that the `CuboidVolumeBuilder` is not generating any envelope around the generated layer which results in overlapping surfaces which does not play nicely with navigation. discovered in #2532
github-actions
bot
added
Infrastructure
acts-project-service
added
the
Fails Athena tests
andiwand
added a commit
to andiwand/acts
that referenced
this pull request
Oct 20, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
Fixes an oversight in #2532
andiwand
added a commit
to andiwand/acts
that referenced
this pull request
Oct 20, 2023
…cts-project#2532) I think the accuracy property of the `ConstrainedStep` should always be positive as we want to use it consistently in back stepping. I encountered a situation where the overstepping was not accurate enough (the overstepping step exceeded the eigen stepper error tolerance), then the step length reduction mechanism fails and ends in an endless loop. Pulled this out of acts-project#2518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the accuracy property of the
ConstrainedStepshould always be positive as we want to use it consistently in back stepping.I encountered a situation where the overstepping was not accurate enough (the overstepping step exceeded the eigen stepper error tolerance), then the step length reduction mechanism fails and ends in an endless loop.
Pulled this out of #2518