refactor: Refactor loop protection #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
- Coverage 49.77% 49.76% -0.01%
==========================================
Files 466 466
Lines 26322 26326 +4
Branches 12095 12097 +2
==========================================
Hits 13101 13101
- Misses 4621 4624 +3
- Partials 8600 8601 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
previously approved these changes
Oct 16, 2023
github-actions
bot
added
the
Infrastructure
paulgessinger
approved these changes
Oct 16, 2023
acts-project-service
added
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
These changes make the path limit more sound in the CKF. Before we did not respect the path limit during target surface propagation which can result in propagation step overflow for loopers. At the same time I tried to improve the error handling by not aborting the whole propagation in case of an error but keep going on until we handled all branches. This is not fully communicated downstream yet but will still result in error logs we can catch. Pulled out of #2518 bocked by - #2535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop protection should not be direction dependent anymore. The limit should be set even if it is higher.
Pulled this out of #2518