fix: Fix and refactor PathLimitReached

[andiwand]

PathLimitReached should not update the step length if it already reached its target

Pulled this out of #2518

[github-actions]

📊: Physics performance monitoring for 6cebeda

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[acts-project-service]

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🟢	run_unit_tests
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🔴	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🔴	run_workflow_tests_run2_data
🔴	run_workflow_tests_run3_mc
🔴	run_workflow_tests_run3_data

[andiwand]

looks like we somehow depended on that behavior in athena? do you know what the workflow is doing? @paulgessinger

[paulgessinger]

This is a bit odd.

[paulgessinger]

Job itself looks fine, so maybe the memory monitor freaks out about something?

[paulgessinger]

Ah, actually, we get a(nother) failure of the CKF reaching the maximum number of steps:

09:40:49 ActsTrackFindingAlg.Acts                            ERROR CombinatorialKalmanFilter failed: CombinatorialKalmanFilterError:5 Propagation reaches max steps before track finding is finished with the initial parameters:
09:40:49     545.01
09:40:49 -0.0141381
09:40:49   -2.42849
09:40:49    2.88981
09:40:49   -1.72882
09:40:49    2376.46
09:40:49 ActsTrackFindingAlg                               WARNING Track finding failed for strip seed 483 with errorCombinatorialKalmanFilterError:5

[paulgessinger]

Triggered a new pipeline with a patched error filter pattern: https://gitlab.cern.ch/acts/acts-athena-ci/-/pipelines/6327698

• ART ignore pattern also needs to be updated!

[paulgessinger]

Ok, the error pattern in the test seems to be working.

@CarloVarni Do you think we should actually add the ignore pattern in ART already, or do we wait for the error to actually appear? Naively, I'd think seeing it fail before ignoring the error is probably the better approach?