Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve ConstrainedStep footprint after #2532 #2561

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

andiwand
Copy link
Contributor

Fixes an oversight in #2532

@andiwand andiwand added this to the next milestone Oct 20, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Oct 20, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2561 (4e04150) into main (187b83c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2561   +/-   ##
=======================================
  Coverage   49.82%   49.82%           
=======================================
  Files         468      468           
  Lines       26509    26509           
  Branches    12180    12180           
=======================================
  Hits        13209    13209           
  Misses       4633     4633           
  Partials     8667     8667           
Files Coverage Δ
Core/include/Acts/Propagator/ConstrainedStep.hpp 68.88% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 185d0da into acts-project:main Oct 20, 2023
57 checks passed
@andiwand andiwand deleted the improve-after-2532 branch October 20, 2023 13:22
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 20, 2023
@paulgessinger
Copy link
Member

Athena failure is unrelated.

@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants