Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove semicolon after function definition #2566

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

andiwand
Copy link
Contributor

Found this in #2565 and it annoyed me a bit

@andiwand andiwand added this to the next milestone Oct 22, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Seeding Track Finding labels Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #2566 (2c1f48b) into main (9b6cf2f) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #2566   +/-   ##
=======================================
  Coverage   49.64%   49.64%           
=======================================
  Files         471      471           
  Lines       26632    26632           
  Branches    12237    12237           
=======================================
  Hits        13222    13222           
  Misses       4742     4742           
  Partials     8668     8668           
Files Coverage Δ
Core/include/Acts/Propagator/AtlasStepper.hpp 72.15% <100.00%> (ø)
Core/include/Acts/Utilities/FiniteStateMachine.hpp 74.28% <100.00%> (ø)
Core/include/Acts/Utilities/Result.hpp 88.67% <100.00%> (ø)
...ore/include/Acts/Seeding/CandidatesForMiddleSp.hpp 0.00% <0.00%> (ø)
...re/include/Acts/TrackFinding/FasTrackConnector.hpp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not!

@kodiakhq kodiakhq bot merged commit 134fdb1 into acts-project:main Oct 22, 2023
57 checks passed
@andiwand andiwand deleted the chore-ctor-syntax branch October 22, 2023 14:05
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Seeding Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants