feat: add export to json geometry using hierarchy map #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
added
Component - Examples
| // This is a navigation volume, write the boundaries | ||
| if (writeBoundary) { | ||
| for (auto bsurface : volume.boundarySurfaces()) { | ||
| // ; |
There was a problem hiding this comment.
Is it normal that the writing of the boundary does nothing ?
There was a problem hiding this comment.
That's a place-holder, but I think I can add it. For writing the boundaries, I should actually resolve also the volume pointing, but then this would be a different type ... I will add "just" the plain surface information here.
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 49.07% 49.07%
=======================================
Files 331 331
Lines 16568 16568
Branches 7722 7722
=======================================
Hits 8130 8130
Misses 3006 3006
Partials 5432 5432 Continue to review full report at Codecov.
|
Corentin-Allaire
approved these changes
Jan 29, 2021
|
Merging master in & then have a look. |
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
Feb 3, 2021
Adding Surface writing capability to the framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Geometry/Surface converter for the
Geometryexamples in the framework, using theGeometryHierarchyMapConverter<>from the Core repository.It also corrects a faulty include directory from
AtlasExamples/PlugintoAtlasExamples/Io.It needed also a
to_jsonconversion forstd::shared_ptr<const Surface> surfacerather than theconst Surface&.