feat: Extend telescope detector with disc surface #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaocongAi
force-pushed
the
extend-telescope
branch
from
99eda79
to
2a2724b
Compare
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
=======================================
Coverage 49.07% 49.07%
=======================================
Files 331 331
Lines 16568 16568
Branches 7722 7722
=======================================
Hits 8130 8130
Misses 3006 3006
Partials 5432 5432 Continue to review full report at Codecov.
|
...etectors/TelescopeDetector/include/ActsExamples/TelescopeDetector/BuildTelescopeDetector.hpp
Outdated
Show resolved
Hide resolved
...etectors/TelescopeDetector/include/ActsExamples/TelescopeDetector/BuildTelescopeDetector.hpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/TelescopeDetector/src/BuildTelescopeDetector.cpp
Outdated
Show resolved
Hide resolved
|
Hi @paulgessinger , thank you for the suggestions. I have made the update. |
asalzburger
approved these changes
Jan 29, 2021
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
Feb 3, 2021
This PR extends the telescope detector to be configurable with either PlaneSurface or DiscSurface. This will allow for reco test with the DiscSurface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the telescope detector to be configurable with either
PlaneSurfaceorDiscSurface. This will allow for reco test with theDiscSurface.