Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make MaterialSlab construction from JSON explicit #704

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

paulgessinger
Copy link
Member

This somehow worked for @Corentin-Allaire, but I got an error. Making it explicit should be fine.

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't understand why the worked. I approve

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it fixes, it - let's put it in.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #704 (ef99221) into master (478a565) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   49.03%   49.03%           
=======================================
  Files         331      331           
  Lines       16549    16549           
  Branches     7725     7725           
=======================================
  Hits         8115     8115           
  Misses       3013     3013           
  Partials     5421     5421           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478a565...c14d66f. Read the comment docs.

@asalzburger asalzburger merged commit 1ec8987 into acts-project:master Feb 9, 2021
@paulgessinger paulgessinger deleted the mat-fix branch February 9, 2021 14:48
@paulgessinger paulgessinger modified the milestones: next, v6.0.0 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants