fix: use of ordered_json #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Bug
asalzburger
approved these changes
Feb 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
=======================================
Coverage 49.01% 49.01%
=======================================
Files 325 325
Lines 16574 16574
Branches 7744 7744
=======================================
Hits 8124 8124
Misses 3019 3019
Partials 5431 5431 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the material map and tracking geometry where written to file they were not using ordered_json due to an oversight (the ordered_json had been converted to json before being written). This fix this issue so that the key appear in proper order in the files.