-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Examples): Estimate parameters from truth seeds #715
feat(Examples): Estimate parameters from truth seeds #715
Conversation
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
=======================================
Coverage 48.96% 48.96%
=======================================
Files 325 325
Lines 16639 16639
Branches 7762 7762
=======================================
Hits 8147 8147
Misses 3042 3042
Partials 5450 5450
Continue to review full report at Codecov.
|
@XiaocongAi I will not have time to look at this. My apologies. |
Hi @msmk0 , no worries! Thanks! |
Hi @Corentin-Allaire , do you have time to have a look at this PR? |
Yes I will have a look tomorrow, sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I have added a few comments. Also you haven't updated the copyright date of most the file you changed, I don't really mind but I thought I would let you know :)
Examples/Algorithms/TrackFinding/src/TrackParamsEstimationAlgorithm.cpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TrackFinding/src/TrackParamsEstimationAlgorithm.cpp
Outdated
Show resolved
Hide resolved
0865582
to
182bcd1
Compare
Hi @Corentin-Allaire , thank you for the comments and suggestions. I should have addressed all of them. Could you take a further look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
Hi @asalzburger , could you help get this in? |
edcbc1a
to
a1c60c9
Compare
This PR includes the following changes:
SeedingPerformanceWriter
andRooTrackParameterWriter
to take proto tracks as inputs instead of seeds. This could avoid additional transform of the seeds into proto tracks which is required for truth matching.TrackParamsEstimationAlgorithm
to allow for using proto tracks and space points as inputs as well as the seeds. In this way, track parameters could also be estimated from 'seeds ' from truth track finding.std::vector<...>
.