Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Examples): Estimate parameters from truth seeds #715

Conversation

XiaocongAi
Copy link
Contributor

This PR includes the following changes:

  • Change the SeedingPerformanceWriter and RooTrackParameterWriter to take proto tracks as inputs instead of seeds. This could avoid additional transform of the seeds into proto tracks which is required for truth matching.
  • Change the TrackParamsEstimationAlgorithm to allow for using proto tracks and space points as inputs as well as the seeds. In this way, track parameters could also be estimated from 'seeds ' from truth track finding.
  • Simplify the seed container to use std::vector<...>.

@XiaocongAi XiaocongAi added the Component - Examples Affects the Examples module label Feb 15, 2021
@XiaocongAi XiaocongAi added this to the next milestone Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #715 (1ca8e21) into master (26369ab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   48.96%   48.96%           
=======================================
  Files         325      325           
  Lines       16639    16639           
  Branches     7762     7762           
=======================================
  Hits         8147     8147           
  Misses       3042     3042           
  Partials     5450     5450           
Impacted Files Coverage Δ
Core/include/Acts/Seeding/Seed.hpp 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26369ab...e1093ad. Read the comment docs.

@XiaocongAi
Copy link
Contributor Author

Hi @msmk0 , this is a follow-up PR to #621. Do you have time to have a look?

@msmk0
Copy link
Contributor

msmk0 commented Feb 16, 2021

@XiaocongAi I will not have time to look at this. My apologies.

@XiaocongAi
Copy link
Contributor Author

Hi @msmk0 , no worries! Thanks!

@XiaocongAi XiaocongAi removed the request for review from msmk0 February 16, 2021 13:15
@XiaocongAi
Copy link
Contributor Author

Hi @Corentin-Allaire , do you have time to have a look at this PR?

@Corentin-Allaire
Copy link
Contributor

Hi @Corentin-Allaire , do you have time to have a look at this PR?

Yes I will have a look tomorrow, sorry for the delay.

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have added a few comments. Also you haven't updated the copyright date of most the file you changed, I don't really mind but I thought I would let you know :)

@XiaocongAi XiaocongAi force-pushed the estimate-parameters-use-truth-seeds branch from 0865582 to 182bcd1 Compare February 23, 2021 15:44
@XiaocongAi
Copy link
Contributor Author

Hi @Corentin-Allaire , thank you for the comments and suggestions. I should have addressed all of them. Could you take a further look?

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@XiaocongAi
Copy link
Contributor Author

Hi @asalzburger , could you help get this in?

@XiaocongAi XiaocongAi force-pushed the estimate-parameters-use-truth-seeds branch from edcbc1a to a1c60c9 Compare March 2, 2021 16:41
@paulgessinger paulgessinger merged commit 506d1d8 into acts-project:master Mar 3, 2021
@paulgessinger paulgessinger modified the milestones: next, v7.0.0 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants