Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding TGeo digitization example #718

Merged

Conversation

asalzburger
Copy link
Contributor

This mini PR adds the TGeoDigitizationExample analog to all other examples in the AcsExamples.

@asalzburger asalzburger added Component - Examples Affects the Examples module Feature Development to integrate a new feature labels Feb 19, 2021
@asalzburger asalzburger added this to the next milestone Feb 19, 2021
@asalzburger asalzburger self-assigned this Feb 19, 2021
@asalzburger
Copy link
Contributor Author

Hey @niermann999 - this is in preparation for your QT, so I guess you could have a look. That's the smallest PR ever.

Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jep, that was a short read :)

@asalzburger
Copy link
Contributor Author

Waiting for CI to run through.

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #718 (e7fc2ea) into master (3317a35) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   49.02%   49.02%           
=======================================
  Files         325      325           
  Lines       16574    16574           
  Branches     7744     7744           
=======================================
  Hits         8126     8126           
  Misses       3017     3017           
  Partials     5431     5431           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3317a35...c690bc4. Read the comment docs.

@asalzburger asalzburger merged commit 4a60176 into acts-project:master Feb 22, 2021
@paulgessinger paulgessinger modified the milestones: next, v6.0.0 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants