-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow external logger for ActsFatras/Simulator #728
Conversation
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=======================================
Coverage 48.90% 48.90%
=======================================
Files 325 325
Lines 16701 16701
Branches 7796 7796
=======================================
Hits 8168 8168
Misses 3062 3062
Partials 5471 5471 Continue to review full report at Codecov.
|
Hi @yifever - do you need some guidance/help on this to bet it going? @FabianKlimpel will soon be in the position to merge the #574 in, then we could aim at a Fatras feature release. |
Hi @FabianKlimpel and @asalzburger |
I think I need someone to add a milestone for me. I am not a contributor and I am not sure I have that permission. (I have 0 experience in github and if there is a way for me to do this I apologize in advance for not finding the button.) |
Ok, set the milestone and triggered merging of master into this, let's see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming convention changes & some other small remarks.
Hi @asalzburger Can you look at the new changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in
I'm overriding the missing coverage results. |
Add a feature to use external loggers in ActsFatras. This feature is useful for running ActsFatras inside athena.
Add a feature to use external loggers in ActsFatras. This feature is useful for running ActsFatras inside athena.