Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Allow configurable BField in vertexing examples #738

Conversation

baschlag
Copy link
Contributor

@baschlag baschlag commented Mar 2, 2021

  • With the vertexing code previously being templated on the bfield type, a hardcoded ConstantBField was used for simplicity in the Examples. After refactor!: Steppers use MagneticFieldProvider (2/2) #675 went in, a configurable BField can now easily be used and set in the example options.
    This PR changes the Examples accordingly.
  • Additionally some clean-up is done and Stepper typedefs like
using Stepper = Acts::EigenStepper<>;

are removed and the type is used explicitly instead.

Closes #735

@baschlag baschlag added Component - Documentation Affects the documentation Component - Examples Affects the Examples module Improvement Changes to an existing feature labels Mar 2, 2021
@baschlag baschlag added this to the next milestone Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #738 (af84b54) into master (12f1247) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #738   +/-   ##
=======================================
  Coverage   48.96%   48.96%           
=======================================
  Files         325      325           
  Lines       16639    16639           
  Branches     7762     7762           
=======================================
  Hits         8147     8147           
  Misses       3042     3042           
  Partials     5450     5450           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f1247...29f27c6. Read the comment docs.

@asalzburger asalzburger self-requested a review March 2, 2021 16:52
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight-forward adaption to the new MagneticField handling.

@asalzburger asalzburger merged commit 31562d0 into acts-project:master Mar 4, 2021
@paulgessinger paulgessinger modified the milestones: next, v7.0.0 Apr 8, 2021
@baschlag baschlag deleted the 735_remove_hardcoded_bfield_vertexing_examples branch May 19, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation Component - Examples Affects the Examples module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not hard-code the B Field type in VertexFitterAlgorithm
3 participants