fix: Use correct conversion from JSON to Material #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 325 325
Lines 16682 16682
Branches 7791 7791
=======================================
Hits 8151 8151
Misses 3061 3061
Partials 5470 5470 Continue to review full report at Codecov.
|
|
In principle this looks fine, but the material conversion unit tests seem to fail. Could you have a look? |
paulgessinger
changed the title
|
it is fixed now |
|
Updating - @Corentin-Allaire - can you review, please? |
Corentin-Allaire
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two lines in
MaterialJsonConverter.cppof Json plugins showed the following compile error:call of overloaded ‘Material(const value_type&)’ is ambiguousLooks like "at" method of json objects causes the ambiguity issue, so I changed it to "get" method to resolve it (suggested by @paulgessinger)