Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: csv surface grid writer #761

Merged

Conversation

asalzburger
Copy link
Contributor

This PR adds a new CVS writer component to be able to write out the Detector surfaces for navigation inspection.

itk_vol_10_lay_28

@asalzburger asalzburger added Improvement Changes to an existing feature Component - Examples Affects the Examples module labels Mar 30, 2021
@asalzburger asalzburger added this to the next milestone Mar 30, 2021
@asalzburger asalzburger self-assigned this Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #761 (9186aa6) into master (464c247) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   48.88%   48.88%           
=======================================
  Files         325      325           
  Lines       16689    16689           
  Branches     7793     7793           
=======================================
  Hits         8158     8158           
  Misses       3062     3062           
  Partials     5469     5469           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464c247...9186aa6. Read the comment docs.

Copy link
Contributor

@robertlangenberg robertlangenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go in from my side

@asalzburger
Copy link
Contributor Author

Merging master in.

@asalzburger asalzburger merged commit 5038ab6 into acts-project:master Mar 31, 2021
@paulgessinger paulgessinger modified the milestones: next, v7.0.0 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants