refactor: Move ODD into thirdparty #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the ODD xml and factories into thirdparty, where the upstream source is at https://github.com/acts-project/OpenDataDetector. The DD4hep Detector target is modified to pick up on the factories in that location
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
=======================================
Coverage 48.90% 48.90%
=======================================
Files 325 325
Lines 16701 16701
Branches 7796 7796
=======================================
Hits 8168 8168
Misses 3062 3062
Partials 5471 5471 Continue to review full report at Codecov.
|
asalzburger
approved these changes
Apr 9, 2021
FabianKlimpel
pushed a commit
to FabianKlimpel/acts
that referenced
this pull request
Apr 29, 2021
This PR moves the Open Data Detector into a separate repo and and a copy of it into `thirdparty`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the ODD xml and factories into thirdparty, where the upstream
source is at https://github.com/acts-project/OpenDataDetector. The
DD4hep Detector target is modified to pick up on the factories in that
location