feat: material mapping fixes odd #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
added
Bug
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 48.73% 48.73%
=======================================
Files 328 328
Lines 16868 16868
Branches 7915 7915
=======================================
Hits 8220 8220
Misses 3062 3062
Partials 5586 5586
Continue to review full report at Codecov.
|
Examples/Detectors/DD4hepDetector/src/TestTracker/ZPlanarTracker_geo.cpp
Outdated
Show resolved
Hide resolved
asalzburger
force-pushed
the
feat-material-mapping-fixes-odd
branch
from
f8a2595
to
8b268da
Compare
Corentin-Allaire
approved these changes
Apr 19, 2021
gagnonlg
pushed a commit
to gagnonlg/acts
that referenced
this pull request
May 11, 2021
This PR fixes a few things in the material mapping and DD4Hep description: ODD has now by-hand-envelopes (fixes navigation issues), copy and repo is updated Pre/Post step of material user action was wrongly calculated Naming convention is fixed in HierachySurface... and HierarchyVolume... Still an issue of not being able to map onto the last boundary surfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things in the material mapping and DD4Hep description:
HierachySurface...andHierarchyVolume...Still an issue of not being able to map onto the last boundary surfaces: