Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: division by 0 in SpacePointGrid #779

Merged
merged 7 commits into from
May 4, 2021
Merged

fix: division by 0 in SpacePointGrid #779

merged 7 commits into from
May 4, 2021

Conversation

robertlangenberg
Copy link
Contributor

For no magnetic field or pseudorapidity == 0, the SpacePointGrid now creates 100 phi bins respectively 100 z bins instead of crashing

@robertlangenberg
Fix division by 0 in SpacePointGrid
8266fbd 
For no magnetic field or pseudorapidity == 0, the SpacePointGrid now creates 100 phi bins respectively 100 z bins instead of crashing
@robertlangenberg robertlangenberg added this to the next milestone Apr 20, 2021
@robertlangenberg robertlangenberg changed the title Fix: division by 0 in SpacePointGrid fix: division by 0 in SpacePointGrid Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021 •
edited

Codecov Report

Merging #779 (c6240c2) into master (466691d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
- Coverage   48.67%   48.65%   -0.02%     
==========================================
  Files         328      328              
  Lines       16889    16895       +6     
  Branches     7930     7932       +2     
==========================================
  Hits         8220     8220              
- Misses       3072     3078       +6     
  Partials     5597     5597
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SpacePointGrid.ipp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466691d...c6240c2. Read the comment docs.

@paulgessinger paulgessinger linked an issue May 3, 2021 that may be closed by this pull request
Bug: MagField with 0 z-component causes vector::_M_default_append when Acts::SpacePointGridCreator::createGrid is called #764
Closed
paulgessinger
paulgessinger approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robertlangenberg robertlangenberg added the 🚧 WIP Work-in-progress label May 3, 2021
@robertlangenberg robertlangenberg removed the 🚧 WIP Work-in-progress label May 3, 2021
@robertlangenberg robertlangenberg merged commit 45e5289 into master May 4, 2021
@robertlangenberg robertlangenberg deleted the spacepointgrid-divby0 branch May 5, 2021 07:29
@paulgessinger paulgessinger modified the milestones: next, v8.2.0 May 10, 2021
gagnonlg pushed a commit to gagnonlg/acts that referenced this pull request May 11, 2021
@robertlangenberg @gagnonlg
fix: division by 0 in SpacePointGrid (acts-project#779)
274b221 
* Fix division by 0 in SpacePointGrid

For no magnetic field or pseudorapidity == 0, the SpacePointGrid now creates 100 phi bins respectively 100 z bins instead of crashing

* support negative magnetic field and make sure zBins never < 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.2.0
2 participants
@robertlangenberg @paulgessinger