refactor: Change min json version to 3.2.0 and bundle 3.9.1 #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
changed the title
Corentin-Allaire
added
Component - Plugins
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
=======================================
Coverage 48.73% 48.73%
=======================================
Files 328 328
Lines 16868 16868
Branches 7915 7915
=======================================
Hits 8220 8220
Misses 3062 3062
Partials 5586 5586 Continue to review full report at Codecov.
|
Corentin-Allaire
changed the title
paulgessinger
changed the title
paulgessinger
changed the title
paulgessinger
approved these changes
Apr 23, 2021
paulgessinger
changed the title
gagnonlg
pushed a commit
to gagnonlg/acts
that referenced
this pull request
Apr 27, 2021
…ject#780) To accommodate the json version shipped with LCG used by ATLAS we change the minimum json version was reverted back 3.2.0 as it was before acts-project#750 . To use the json plugin with GCC >10 a version of json more recent that 3.7.4 is actually needed so for the time being in propose to use 3.9.1 as the version shiped with Acts.
gagnonlg
pushed a commit
to gagnonlg/acts
that referenced
this pull request
May 11, 2021
…ject#780) To accommodate the json version shipped with LCG used by ATLAS we change the minimum json version was reverted back 3.2.0 as it was before acts-project#750 . To use the json plugin with GCC >10 a version of json more recent that 3.7.4 is actually needed so for the time being in propose to use 3.9.1 as the version shiped with Acts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To accommodate the json version shipped with LCG used by ATLAS we change the minimum json version was reverted back 3.2.0 as it was before #750 . To use the json plugin with GCC >10 a version of json more recent that 3.7.4 is actually needed so for the time being in propose to use 3.9.1 as the version shiped with Acts.