feat: adding DD4hep digitization, fix measurement writer, add variance in o… #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
added
Component - Examples
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
=======================================
Coverage 48.67% 48.67%
=======================================
Files 328 328
Lines 16889 16889
Branches 7930 7930
=======================================
Hits 8220 8220
Misses 3072 3072
Partials 5597 5597 Continue to review full report at Codecov.
|
noemina
approved these changes
Apr 28, 2021
niermann999
reviewed
Apr 28, 2021
| @@ -209,6 +211,19 @@ class RootMeasurementWriter final : public WriterT<MeasurementContainer> { | |||
| recBound[Acts::eBoundPhi] = fullVect[Acts::eBoundPhi]; | |||
| recBound[Acts::eBoundTheta] = fullVect[Acts::eBoundTheta]; | |||
| recBound[Acts::eBoundTime] = fullVect[Acts::eBoundTime]; | |||
|
|
|||
| Acts::BoundSymMatrix fullVar = | |||
| m.expander() * m.covariance() * m.expander().transpose(); | |||
There was a problem hiding this comment.
For my understanding: Should the second transform not just be the projection?
There was a problem hiding this comment.
Ja, but it operates on a matrix.
There was a problem hiding this comment.
Ok, I just thought that .expander.transpose was be the same as .projection, with the latter being preferred
gagnonlg
pushed a commit
to gagnonlg/acts
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
clustersnot being present when running smearing onlyRootMeasurementWriterin order to be able to do pulls/variance checks