feat: add track picking and truth seed selection #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
added
Improvement
asalzburger
changed the title
Codecov Report
@@ Coverage Diff @@
## main #786 +/- ##
=======================================
Coverage 48.65% 48.65%
=======================================
Files 328 328
Lines 16895 16895
Branches 7932 7932
=======================================
Hits 8220 8220
Misses 3078 3078
Partials 5597 5597 Continue to review full report at Codecov.
|
XiaocongAi
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Hi @asalzburger , it looks all good except one naming you might want to fix.
Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TruthSeedSelector.cpp
Outdated
Show resolved
Hide resolved
asalzburger
force-pushed
the
feat-add-track-picking
branch
from
4cb0002
to
164c47b
Compare
asalzburger
force-pushed
the
feat-add-track-picking
branch
from
b15c5d2
to
5196e79
Compare
|
This has been approved by @XiaocongAi already, we lost the approval via the |
gagnonlg
pushed a commit
to gagnonlg/acts
that referenced
this pull request
May 11, 2021
This PR addresses (at least partly) acts-project#775. It adds: allow for single track picking in TruthTrackFitting for screen debugging feed the TruthSeedSelector with program options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses (at least partly) #775.
It adds: