fix: Write surface only once in the MaterialMapJsonConverter #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Component - Plugins
Corentin-Allaire
changed the title
Corentin-Allaire
changed the title
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
=======================================
Coverage 48.67% 48.67%
=======================================
Files 328 328
Lines 16889 16889
Branches 7930 7930
=======================================
Hits 8220 8220
Misses 3072 3072
Partials 5597 5597 Continue to review full report at Codecov.
|
paulgessinger
approved these changes
Apr 28, 2021
gagnonlg
pushed a commit
to gagnonlg/acts
that referenced
this pull request
May 11, 2021
…oject#787) With this PR when converting a tracking geometry to a Hierarchy the volume that have already been added to the hierarchy won't be added a second time. This solve the issue that if a volume belong to multiple volumes (as it is the case for the Calorimeter in the Acts ATLAS implementation) the code would result in an error (since hierarchy can only have each identifier appear once)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR when converting a tracking geometry to a Hierarchy the volume that have already been added to the hierarchy won't be added a second time. This solve the issue that if a volume belong to multiple volumes (as it is the case for the Calorimeter in the Acts ATLAS implementation) the code would result in an error (since hierarchy can only have each identifier appear once)