Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove usage of using namespace in headers #807

Merged
merged 2 commits into from
May 25, 2021

Conversation

paulgessinger
Copy link
Member

We got a bit lenient with not doing

using namespace Acts::UnitLiterals;

in header code. This is a bad idea, because it pollutes the global namespace in every compilation unit such a header is included in. As a workaround, you can put using namespace in any functions where the literals are needed.

This PR removes all of these cases, and also removes a few other instances of using namespace in headers.

@paulgessinger paulgessinger added this to the next milestone May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #807 (badade0) into main (31faea5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   48.64%   48.64%           
=======================================
  Files         328      328           
  Lines       16900    16900           
  Branches     7935     7935           
=======================================
  Hits         8221     8221           
  Misses       3080     3080           
  Partials     5599     5599           
Impacted Files Coverage Δ
Core/include/Acts/Propagator/AtlasStepper.hpp 69.36% <ø> (ø)
Core/include/Acts/Propagator/EigenStepper.hpp 67.56% <ø> (ø)
Core/include/Acts/Propagator/Navigator.hpp 57.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31faea5...badade0. Read the comment docs.

@asalzburger asalzburger self-requested a review May 25, 2021 08:32
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward cleanup.

@asalzburger
Copy link
Contributor

Update and merge afterwards

@asalzburger asalzburger merged commit 053c53b into acts-project:main May 25, 2021
@asalzburger
Copy link
Contributor

Sorry, forgot to add the explanation in the merge commit.

@paulgessinger paulgessinger modified the milestones: next, v8.3.0 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants