-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update performance plotting scripts #814
feat: update performance plotting scripts #814
Conversation
Codecov Report
@@ Coverage Diff @@
## main #814 +/- ##
=======================================
Coverage 48.65% 48.65%
=======================================
Files 327 327
Lines 16910 16910
Branches 7944 7944
=======================================
Hits 8227 8227
Misses 3079 3079
Partials 5604 5604 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @asalzburger , thank you for implementing those plotting functions. They look all good except a minor comment you might want to address.
On a side note, I think in the longer term it might be better for us to make the performance plots based on the persistified tracks in the root files since this could gives us more flexibility regarding the definition of the performance, the binning of the variables etc. and more importantly, we don't have to redo the reconstruction just in order to remake the performance plots.
Co-authored-by: Xiaocong Ai <xiaocong.ai@cern.ch>
Co-authored-by: Xiaocong Ai <xiaocong.ai@cern.ch>
This updates the performance scripts as suggested.