Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update performance plotting scripts #814

Merged

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented May 25, 2021

This updates the performance scripts as suggested.

@asalzburger asalzburger added this to the next milestone May 25, 2021
@asalzburger asalzburger changed the title update performance plotting scripts feat: update performance plotting scripts May 25, 2021
@asalzburger asalzburger self-assigned this May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #814 (9cb40ba) into main (e20c66e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   48.65%   48.65%           
=======================================
  Files         327      327           
  Lines       16910    16910           
  Branches     7944     7944           
=======================================
  Hits         8227     8227           
  Misses       3079     3079           
  Partials     5604     5604           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e20c66e...9cb40ba. Read the comment docs.

Copy link
Contributor

@XiaocongAi XiaocongAi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asalzburger , thank you for implementing those plotting functions. They look all good except a minor comment you might want to address.
On a side note, I think in the longer term it might be better for us to make the performance plots based on the persistified tracks in the root files since this could gives us more flexibility regarding the definition of the performance, the binning of the variables etc. and more importantly, we don't have to redo the reconstruction just in order to remake the performance plots.

@asalzburger asalzburger merged commit d72e80c into acts-project:main May 28, 2021
@asalzburger asalzburger deleted the feat-update-param-resoluiton-script branch May 28, 2021 13:37
@paulgessinger paulgessinger modified the milestones: next, v9.0.0 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants