-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Simplified implementation of StepperExtensionList #817
refactor: Simplified implementation of StepperExtensionList #817
Conversation
Codecov Report
@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 48.64% 48.63% -0.01%
==========================================
Files 328 327 -1
Lines 16900 16906 +6
Branches 7935 7944 +9
==========================================
+ Hits 8221 8223 +2
+ Misses 3080 3079 -1
- Partials 5599 5604 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, good idea. I think it's effectively exactly the same, but you can write it a lot more compact this way and there's no need to add extra types.
I think most of us (or me at least) are not super comfortable with fold expressions yet, but this is the way.
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
In this PR I propose a simplified implementation of the
StepperExtensionList
. I'm currently working with it, and I found it first quite difficult to look through the structure, and then also not so handy to change things (must be always changed both in implementation and the interface class...)With this proposal, I reimplemented the same functionality with some fold expressions and lambdas, and at least to me it is now a lot clearer what is done here, and everything is in one file.