Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make intersection verbose logging a lot more verbose #827

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

paulgessinger
Copy link
Member

Debugging intersection issues is tricky. This PR adds LoggerWrapper to the surface update function, enabling it to provide more granular verbose log output. The output is structured to make it easy to understand what is going on during the intersection calculation.

@paulgessinger paulgessinger added the 🚧 WIP Work-in-progress label Jun 3, 2021
@paulgessinger paulgessinger added this to the next milestone Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #827 (a7b24b1) into main (b00d3dd) will decrease coverage by 0.03%.
The diff coverage is 26.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   48.51%   48.47%   -0.04%     
==========================================
  Files         329      329              
  Lines       16952    16974      +22     
  Branches     8006     8028      +22     
==========================================
+ Hits         8224     8228       +4     
- Misses       3087     3091       +4     
- Partials     5641     5655      +14     
Impacted Files Coverage Δ
.../include/Acts/Propagator/detail/SteppingHelper.hpp 40.00% <0.00%> (-18.34%) ⬇️
Core/include/Acts/Propagator/Navigator.hpp 57.11% <8.33%> (-0.40%) ⬇️
Core/src/Geometry/TrackingVolume.cpp 43.51% <40.00%> (+0.15%) ⬆️
Core/include/Acts/Propagator/AtlasStepper.hpp 68.55% <100.00%> (ø)
Core/include/Acts/Propagator/EigenStepper.hpp 67.56% <100.00%> (ø)
...re/include/Acts/Propagator/StraightLineStepper.hpp 67.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00d3dd...a7b24b1. Read the comment docs.

@paulgessinger paulgessinger removed the 🚧 WIP Work-in-progress label Jun 10, 2021
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, it is nice to have access to more output on the intersection !

@paulgessinger paulgessinger merged commit 3776c00 into acts-project:main Jun 10, 2021
@paulgessinger paulgessinger deleted the intersection-logging branch June 10, 2021 13:16
@paulgessinger paulgessinger modified the milestones: next, v9.0.0 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants