Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing radial extent #829

Merged
merged 2 commits into from
Jun 4, 2021
Merged

fix: Added missing radial extent #829

merged 2 commits into from
Jun 4, 2021

Conversation

whit2333
Copy link
Contributor

@whit2333 whit2333 commented Jun 3, 2021

  • Not sure why it is needed but the ProtoLayer construction does not set the values.

See the discussion here

- Not sure why it is needed but the ProtoLayer does not seem to know
about this in the case.
@whit2333 whit2333 changed the title fix: Added missing extent fix: Added missing radial extent Jun 3, 2021
@paulgessinger paulgessinger added this to the next milestone Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #829 (52f0511) into main (b6371e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         328      328           
  Lines       16958    16958           
  Branches     7999     7999           
=======================================
  Hits         8233     8233           
  Misses       3082     3082           
  Partials     5643     5643           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6371e2...52f0511. Read the comment docs.

@asalzburger
Copy link
Contributor

Updating the with main.

@asalzburger asalzburger merged commit d930e7e into acts-project:main Jun 4, 2021
@paulgessinger paulgessinger modified the milestones: next, v9.0.0 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants