Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add track summary root writer and standalone script for reco performance plots #841

Merged
merged 13 commits into from
Jun 17, 2021

Conversation

XiaocongAi
Copy link
Contributor

This PR includes the following changes:

  • Add root writer for event-wise writing of track summary info, e.g. nMeasurements , nOutliers and fitted track parmeters of all reconstructed tracks
  • Add script for making reco performance plots based on two types of root files: the track summary root file and the truth track finding performance root file (which contains the truth particle info). This allows for more flexible and standalone performance validation compared to writing out the performance plots along with reconstruction.

NB: In principle, the track summary info can also write out the corresponding truth particle info for each reconstructed track. In this sense, it can supersede the current RootTrajectoryParametersWriter. This will be handled in a follow-up PR.

@XiaocongAi XiaocongAi added this to the WIP milestone Jun 11, 2021
@XiaocongAi XiaocongAi removed the request for review from asalzburger June 11, 2021 22:11
@XiaocongAi XiaocongAi added the Component - Examples Affects the Examples module label Jun 11, 2021
@XiaocongAi XiaocongAi changed the title perf: Write track summary root writer and add standalone script for reco performance plots perf: Add track summary root writer and standalone script for reco performance plots Jun 11, 2021
@XiaocongAi XiaocongAi modified the milestones: WIP, next Jun 11, 2021
@XiaocongAi XiaocongAi added the 🚧 WIP Work-in-progress label Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #841 (6f32552) into main (af36fb1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   48.47%   48.47%           
=======================================
  Files         329      329           
  Lines       16975    16975           
  Branches     8028     8028           
=======================================
  Hits         8228     8228           
  Misses       3092     3092           
  Partials     5655     5655           
Impacted Files Coverage Δ
.../include/Acts/EventData/MultiTrajectoryHelpers.hpp 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af36fb1...6f32552. Read the comment docs.

@XiaocongAi XiaocongAi removed the 🚧 WIP Work-in-progress label Jun 12, 2021
@XiaocongAi
Copy link
Contributor Author

Hi @asalzburger , could you help have a look?

@asalzburger
Copy link
Contributor

This is fine to go, as it only adds new code & hardly touches existing code I will forward merge it in.

@asalzburger asalzburger merged commit 902c169 into acts-project:main Jun 17, 2021
@paulgessinger paulgessinger modified the milestones: next, v0.9.1 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants