fix: Howto material without spread #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Component - Documentation
Corentin-Allaire
changed the title
Codecov Report
@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 48.46% 48.46%
=======================================
Files 329 329
Lines 16974 16974
Branches 8028 8028
=======================================
Hits 8227 8227
Misses 3092 3092
Partials 5655 5655 Continue to review full report at Codecov.
|
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
paulgessinger
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Howto for material mapping. Include the fact that the Z0 and D0 sigma need to be set to 0 in the validation to be correctly compare to the Geantino scan.
Also modify the root script to take into account that the Geantino scan is flat in theta where the Validation is flat in eta.