fix: DiscBounds binningValue incorrect for binPhi #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DiscBounds` has special logic for `binR`, where it asks its `DiscBounds` for a binning value. This logic is not invoked for `binPhi`, which I believe it should. Added a unit test to assert this behavior.
Codecov Report
@@ Coverage Diff @@
## main #852 +/- ##
==========================================
+ Coverage 48.46% 48.53% +0.07%
==========================================
Files 329 329
Lines 16974 16974
Branches 8028 8025 -3
==========================================
+ Hits 8227 8239 +12
+ Misses 3092 3083 -9
+ Partials 5655 5652 -3
Continue to review full report at Codecov.
|
Corentin-Allaire
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscBoundshas special logic forbinR, where it asks itsDiscBoundsfor a binning value. This logic is not invoked forbinPhi, which I believe it should. Added a unit test to assert this behavior.Also I believe binning value should be in global coordinates here. Previously this worked if local-to-global was only a translation along
z, because the centerzposition was explicitly added. I think generically it should be global, therefore I changed it to apply the transform./cc @asalzburger @Corentin-Allaire