Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add digitization config and example for dd4hep and generic detector #856

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Jun 24, 2021

This PR adds the possibility to run digitization configuration not only on TGeo detectors, but also for

  • DD4hep input
  • Generic input

It also fixes a problem of estimating the number of bins in the DigitizationConfigurator, and finally adds a compactify() option that at least groups some of the digitization configurations together per layer and volume. The latter needed a bunch of operator==() in BinningData and BinUtility.

UnitTests for these are added as well.

In addition, it adds a default geometric-digit configuration file for the GenericDetector.

@asalzburger asalzburger added Bug Something isn't working Component - Core Affects the Core module Component - Examples Affects the Examples module Feature Development to integrate a new feature labels Jun 24, 2021
@asalzburger asalzburger added this to the next milestone Jun 24, 2021
@asalzburger asalzburger self-assigned this Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #856 (30347cd) into main (9d4bb30) will decrease coverage by 0.01%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   48.70%   48.68%   -0.02%     
==========================================
  Files         331      331              
  Lines       17115    17126      +11     
  Branches     8075     8084       +9     
==========================================
+ Hits         8336     8338       +2     
- Misses       3089     3090       +1     
- Partials     5690     5698       +8     
Impacted Files Coverage Δ
...ore/include/Acts/Geometry/GeometryObjectSorter.hpp 46.66% <ø> (ø)
Core/include/Acts/Propagator/Propagator.hpp 89.74% <ø> (ø)
Core/include/Acts/Utilities/BinningData.hpp 63.84% <12.50%> (-2.44%) ⬇️
Core/include/Acts/Utilities/BinUtility.hpp 45.45% <33.33%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4bb30...30347cd. Read the comment docs.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely ok with me.

@asalzburger asalzburger force-pushed the feat-add-digitization-config-example-dd4hep branch from 7f092be to 7d5e4c8 Compare June 30, 2021 06:52
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm fine to merge this.

@asalzburger asalzburger merged commit d911434 into acts-project:main Jun 30, 2021
@asalzburger asalzburger deleted the feat-add-digitization-config-example-dd4hep branch June 30, 2021 11:27
@paulgessinger paulgessinger modified the milestones: next, v9.2.0 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Core Affects the Core module Component - Examples Affects the Examples module Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants