-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add digitization config and example for dd4hep and generic detector #856
feat: add digitization config and example for dd4hep and generic detector #856
Conversation
Codecov Report
@@ Coverage Diff @@
## main #856 +/- ##
==========================================
- Coverage 48.70% 48.68% -0.02%
==========================================
Files 331 331
Lines 17115 17126 +11
Branches 8075 8084 +9
==========================================
+ Hits 8336 8338 +2
- Misses 3089 3090 +1
- Partials 5690 5698 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely ok with me.
Examples/Run/Digitization/Common/detail/DigitizationConfigurator.hpp
Outdated
Show resolved
Hide resolved
Examples/Run/Digitization/Common/detail/DigitizationConfigurator.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
7f092be
to
7d5e4c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm fine to merge this.
This PR adds the possibility to run digitization configuration not only on
TGeo
detectors, but also forDD4hep
inputGeneric
inputIt also fixes a problem of estimating the number of bins in the
DigitizationConfigurator
, and finally adds acompactify()
option that at least groups some of the digitization configurations together per layer and volume. The latter needed a bunch ofoperator==()
inBinningData
andBinUtility
.UnitTests for these are added as well.
In addition, it adds a default
geometric-digit
configuration file for theGenericDetector
.