refactor: Move clusterization functions to core #858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the clusterization function from the Digitization plugin to core. At the same time, change the cell energy field to activation, and the energy cut to a threshold instead to make the semantic more generally applicable than only at digitization level. Also add a static concept check on the cell type.
This does not change the public API, but since we plan to use this function in Athena this may need to fall under semver at some point in the future.
cc @asalzburger