Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move clusterization functions to core #858

Merged
merged 5 commits into from
Jun 29, 2021

Conversation

gagnonlg
Copy link
Contributor

@gagnonlg gagnonlg commented Jun 25, 2021

Move the clusterization function from the Digitization plugin to core. At the same time, change the cell energy field to activation, and the energy cut to a threshold instead to make the semantic more generally applicable than only at digitization level. Also add a static concept check on the cell type.

This does not change the public API, but since we plan to use this function in Athena this may need to fall under semver at some point in the future.

cc @asalzburger

@gagnonlg gagnonlg added this to the next milestone Jun 25, 2021
@gagnonlg gagnonlg added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins labels Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #858 (a5c720a) into main (4c6c00a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   48.65%   48.70%   +0.04%     
==========================================
  Files         330      331       +1     
  Lines       17076    17115      +39     
  Branches     8053     8075      +22     
==========================================
+ Hits         8309     8336      +27     
  Misses       3089     3089              
- Partials     5678     5690      +12     
Impacted Files Coverage Δ
...ore/include/Acts/Clusterization/Clusterization.ipp 69.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6c00a...a5c720a. Read the comment docs.

@asalzburger
Copy link
Contributor

Looks good - we should probably also see what we do with the SparseCCL algorithm in the future.

@asalzburger asalzburger merged commit 9d4bb30 into acts-project:main Jun 29, 2021
@paulgessinger paulgessinger modified the milestones: next, v9.2.0 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants