Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing include in PolymorphicValueTest.cpp #859

Conversation

gagnonlg
Copy link
Contributor

#855 broke the build on my end because of a missing include in a test file. Here we simply add that include, and all is well.
cc @paulgessinger

@gagnonlg gagnonlg added this to the next milestone Jun 25, 2021
@gagnonlg gagnonlg added the Bug Something isn't working label Jun 25, 2021
@gagnonlg gagnonlg force-pushed the fix-missing-include-polymorphicvaluetest branch from cceb0ea to 205b847 Compare June 25, 2021 17:11
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #859 (205b847) into main (3bb5609) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #859   +/-   ##
=======================================
  Coverage   48.65%   48.65%           
=======================================
  Files         330      330           
  Lines       17076    17076           
  Branches     8053     8053           
=======================================
  Hits         8309     8309           
  Misses       3089     3089           
  Partials     5678     5678           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb5609...205b847. Read the comment docs.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this didn't break for me.

@paulgessinger paulgessinger merged commit ed152ac into acts-project:main Jun 27, 2021
@gagnonlg
Copy link
Contributor Author

Weird that this didn't break for me.

I was developping in an athena environment, so likely different from a usual local dev setup

@paulgessinger paulgessinger modified the milestones: next, v9.2.0 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants