Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update open data detector with synchronized endcap modules #867

Merged

Conversation

asalzburger
Copy link
Contributor

This PR updates the ODD to have a synchronised module number in the endcap disks.

lay_5
Screenshot 2021-06-28 at 17 09 02

@asalzburger asalzburger added this to the next milestone Jul 1, 2021
@asalzburger asalzburger self-assigned this Jul 1, 2021
@asalzburger asalzburger added the Feature Development to integrate a new feature label Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #867 (2d3ca80) into main (c7ad7e8) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   48.53%   48.68%   +0.14%     
==========================================
  Files         329      331       +2     
  Lines       16974    17128     +154     
  Branches     8025     8084      +59     
==========================================
+ Hits         8239     8338      +99     
- Misses       3083     3092       +9     
- Partials     5652     5698      +46     
Impacted Files Coverage Δ
Core/include/Acts/Utilities/BinningData.hpp 63.84% <0.00%> (-2.44%) ⬇️
Core/include/Acts/Surfaces/SurfaceArray.hpp 51.78% <0.00%> (-0.95%) ⬇️
Core/include/Acts/Utilities/BinUtility.hpp 45.45% <0.00%> (-0.38%) ⬇️
Core/include/Acts/Utilities/Frustum.hpp 60.00% <0.00%> (ø)
Core/include/Acts/Utilities/Helpers.hpp 65.00% <0.00%> (ø)
Core/include/Acts/Propagator/Navigator.hpp 57.11% <0.00%> (ø)
Core/include/Acts/Seeding/InternalSeed.hpp 0.00% <0.00%> (ø)
Core/include/Acts/Propagator/ActionList.hpp 100.00% <0.00%> (ø)
Core/include/Acts/Propagator/Propagator.hpp 89.74% <0.00%> (ø)
Core/include/Acts/Surfaces/BoundaryCheck.hpp 47.40% <0.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7ad7e8...2d3ca80. Read the comment docs.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulgessinger paulgessinger changed the title feat: update open data detector feat: Update open data detector with synchronized endcap modules Jul 2, 2021
@paulgessinger paulgessinger merged commit d39cc52 into acts-project:main Jul 2, 2021
@paulgessinger paulgessinger modified the milestones: next, v9.2.0 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants